-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py → pyproject.toml #293
setup.py → pyproject.toml #293
Conversation
Thanks, looks good but I'll run a few careful tests before we merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to do this!
A couple of things:
- It appears that the license (and less importantly the platforms) did not make it across from
setup.py
topyproject.toml
. - We should remove the
requirements_doc.txt
andrequirements_test.txt
as they are now redundant, right? Or is there some reason you left them in place?
122cb1d
to
3e852ee
Compare
|
Thanks! That makes sense. But now the github actions are failing because they depend on the old |
3e852ee
to
ce2635f
Compare
ce2635f
to
97c9d80
Compare
The CI jobs pass, I have also updated the documentation. |
Ah yes, good catch. Thanks for your help! |
Unfortunately, I missed an occurrence of Line 27 in 3f7a507
|
Yeah I just noticed that too, I'll take care of it. Thanks! |
Perhaps you need to restore |
My wrong, this is covered by packages:
|
Yup, I came across and implemented the same solution. Builds just passed on readthedocs |
Fxies #288.